Adapted rqt_jtc to newest control_msgs for jtc (backport #643) #659
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
github-actions
bot
requested review from
bmagyar,
destogl,
jackcenter,
jaron-l,
mcbed and
peterdavidfagan
|
I bumped into the same issue on humble today I think... @destogl how about you? |
Originally posted by @destogl in #642 (comment)
Originally posted by @gwalck in #642 (comment) Currently, using rqt_jtc with humble will work but JTC will output a warning because there is a subscriber to the old topic. |
|
@christophfroehlich, should we reopen this? |
(cherry picked from commit b47b42d)
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-643
branch
from
9468a7e to
f00c8ab
Compare
github-actions
bot
requested review from
anfemosa,
aprotyas,
arne48,
duringhof and
mhubii
let's reopen this! @saikishor is working on a fix of rqt_jtc with continuous joints, with the backport we'll be able to backport future fixes too |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## humble #659 +/- ##
==========================================
+ Coverage 44.81% 45.21% +0.40%
==========================================
Files 40 40
Lines 3713 3713
Branches 1769 1769
==========================================
+ Hits 1664 1679 +15
+ Misses 835 820 -15
Partials 1214 1214
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is an automatic backport of pull request #643 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com